List::MoreUtils für kompakteren Code benutzen.

[kivitendo-erp.git] / SL / IC.pm

diff --git a/SL/IC.pm b/SL/IC.pm
index 80781b7f776a300d635ab1163a7ede328c6b030d..5314d4b8e694ca4333e53a27c5b31e9f537745d0 100644 (file)
--- a/SL/IC.pm
+++ b/SL/IC.pm
@@ -35,6 +35,7 @@
 package IC;
 
 use Data::Dumper;
 package IC;
 
 use Data::Dumper;

+use List::MoreUtils qw(all);

 use YAML;
 
 use SL::DBUtils;
 use YAML;
 
 use SL::DBUtils;


@@ -80,10 +81,11 @@ sub get_part {
     $query =
       qq|SELECT p.id, p.partnumber, p.description,
            p.sellprice, p.lastcost, p.weight, a.qty, a.bom, p.unit,
     $query =
       qq|SELECT p.id, p.partnumber, p.description,
            p.sellprice, p.lastcost, p.weight, a.qty, a.bom, p.unit,

-           pg.partsgroup
+           pg.partsgroup, p.price_factor_id, pfac.factor AS price_factor

          FROM parts p
          JOIN assembly a ON (a.parts_id = p.id)
          LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
          FROM parts p
          JOIN assembly a ON (a.parts_id = p.id)
          LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)

+         LEFT JOIN price_factors pfac ON pfac.id = p.price_factor_id

          WHERE (a.id = ?)
          ORDER BY $oid{$myconfig->{dbdriver}}|;
     $sth = prepare_execute_query($form, $dbh, $query, conv_i($form->{id}));
          WHERE (a.id = ?)
          ORDER BY $oid{$myconfig->{dbdriver}}|;
     $sth = prepare_execute_query($form, $dbh, $query, conv_i($form->{id}));


@@ -307,6 +309,8 @@ sub save {
 
   my ($query, $sth);
 
 
   my ($query, $sth);
 

+  my $priceupdate = ', priceupdate = current_date';
+

   if ($form->{id}) {
 
     # get old price
   if ($form->{id}) {
 
     # get old price


@@ -337,6 +341,11 @@ sub save {
     # delete translations
     do_query($form, $dbh, qq|DELETE FROM translation WHERE parts_id = ?|, conv_i($form->{id}));
 
     # delete translations
     do_query($form, $dbh, qq|DELETE FROM translation WHERE parts_id = ?|, conv_i($form->{id}));
 

+    # Check whether or not the prices have changed. If they haven't
+    # then 'priceupdate' should not be updated.
+    my $previous_values = selectfirst_hashref_query($form, $dbh, qq|SELECT * FROM parts WHERE id = ?|, conv_i($form->{id})) || {};
+    $priceupdate        = '' if (all { $previous_values->{$_} == $form->{$_} } qw(sellprice lastcost listprice));
+

   } else {
     my ($count) = selectrow_query($form, $dbh, qq|SELECT COUNT(*) FROM parts WHERE partnumber = ?|, $form->{partnumber});
     if ($count) {
   } else {
     my ($count) = selectrow_query($form, $dbh, qq|SELECT COUNT(*) FROM parts WHERE partnumber = ?|, $form->{partnumber});
     if ($count) {


@@ -392,7 +401,6 @@ sub save {
          sellprice = ?,
          lastcost = ?,
          weight = ?,
          sellprice = ?,
          lastcost = ?,
          weight = ?,

-         priceupdate = ?,

          unit = ?,
          notes = ?,
          formel = ?,
          unit = ?,
          notes = ?,
          formel = ?,


@@ -414,6 +422,7 @@ sub save {
          microfiche = ?,
          partsgroup_id = ?,
          price_factor_id = ?
          microfiche = ?,
          partsgroup_id = ?,
          price_factor_id = ?

+         $priceupdate

        WHERE id = ?|;
   @values = ($form->{partnumber},
              $form->{description},
        WHERE id = ?|;
   @values = ($form->{partnumber},
              $form->{description},


@@ -423,7 +432,6 @@ sub save {
              $form->{sellprice},
              $form->{lastcost},
              $form->{weight},
              $form->{sellprice},
              $form->{lastcost},
              $form->{weight},

-             conv_date($form->{priceupdate}),

              $form->{unit},
              $form->{notes},
              $form->{formel},
              $form->{unit},
              $form->{notes},
              $form->{formel},


@@ -690,9 +698,11 @@ sub assembly_item {
   my $dbh = $form->dbconnect($myconfig);
 
   my $query =
   my $dbh = $form->dbconnect($myconfig);
 
   my $query =

-    qq|SELECT p.id, p.partnumber, p.description, p.sellprice, p.weight, p.onhand, p.unit, pg.partsgroup
+    qq|SELECT p.id, p.partnumber, p.description, p.sellprice, p.weight, p.onhand, p.unit, pg.partsgroup,
+              p.price_factor_id, pfac.factor AS price_factor

        FROM parts p
        LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)
        FROM parts p
        LEFT JOIN partsgroup pg ON (p.partsgroup_id = pg.id)

+       LEFT JOIN price_factors pfac ON pfac.id = p.price_factor_id

        WHERE $where|;
   $form->{item_list} = selectall_hashref_query($form, $dbh, $query, @values);
 
        WHERE $where|;
   $form->{item_list} = selectall_hashref_query($form, $dbh, $query, @values);
 


@@ -914,6 +924,7 @@ sub all_parts {
   if ($form->{l_soldtotal}) {
     push @where_tokens, 'ioi.qty >= 0';
     push @group_tokens, @select_tokens;
   if ($form->{l_soldtotal}) {
     push @where_tokens, 'ioi.qty >= 0';
     push @group_tokens, @select_tokens;

+     map { s/.*\sAS\s+//si } @group_tokens;

     push @select_tokens, 'SUM(ioi.qty)';
   }
 
     push @select_tokens, 'SUM(ioi.qty)';
   }
 


@@ -927,6 +938,7 @@ sub all_parts {
      ordnumber    => 'apoe.', make         => 'mm.',
      quonumber    => 'apoe.', model        => 'mm.',
      invnumber    => 'apoe.', partsgroup   => 'pg.',
      ordnumber    => 'apoe.', make         => 'mm.',
      quonumber    => 'apoe.', model        => 'mm.',
      invnumber    => 'apoe.', partsgroup   => 'pg.',

+     lastcost     => ' ',

      factor       => 'pfac.',
      'SUM(ioi.qty)' => ' ',
   );
      factor       => 'pfac.',
      'SUM(ioi.qty)' => ' ',
   );