DATEV: Warnungen: Uninitialisierte Variablen

[kivitendo-erp.git] / SL / Mailer.pm

diff --git a/SL/Mailer.pm b/SL/Mailer.pm
index 59b521834ce3b91575cbbf7f7cfc52d22f001493..c8fe0f2a4c69eab8898865388787eb51b471bcec 100644 (file)
--- a/SL/Mailer.pm
+++ b/SL/Mailer.pm
@@ -36,7 +36,6 @@ use SL::DB::Employee;
 use SL::Template;
 
 use strict;
 use SL::Template;
 
 use strict;

-use Encode;

 
 my $num_sent = 0;
 
 
 my $num_sent = 0;
 


@@ -118,7 +117,7 @@ sub _create_address_headers {
         $addr_obj->phrase($phrase);
       }
 
         $addr_obj->phrase($phrase);
       }
 

-      push @header_addresses, encode('MIME-Header',$addr_obj->format);
+      push @header_addresses, $addr_obj->format;

     }
 
     push @{ $self->{headers} }, ( ucfirst($item) => join(', ', @header_addresses) ) if @header_addresses;
     }
 
     push @{ $self->{headers} }, ( ucfirst($item) => join(', ', @header_addresses) ) if @header_addresses;


@@ -140,7 +139,6 @@ sub _create_attachment_part {
   $::lxdebug->message(LXDebug->DEBUG2(), "mail5 att=" . $attachment . " email_journal=" . $email_journal . " id=" . $attachment->{id});
 
   if (ref($attachment) eq "HASH") {
   $::lxdebug->message(LXDebug->DEBUG2(), "mail5 att=" . $attachment . " email_journal=" . $email_journal . " id=" . $attachment->{id});
 
   if (ref($attachment) eq "HASH") {

-    $attributes{Path}         = $attachment->{path} || $attachment->{filename};

     $attributes{filename}     = $attachment->{name};
     $file_id                  = $attachment->{id}   || '0';
     $attributes{content_type} = $attachment->{type} || 'application/pdf';
     $attributes{filename}     = $attachment->{name};
     $file_id                  = $attachment->{id}   || '0';
     $attributes{content_type} = $attachment->{type} || 'application/pdf';


@@ -148,8 +146,6 @@ sub _create_attachment_part {
     $attachment_content       = eval { read_file($attachment->{path}) } if !$attachment_content;
 
   } else {
     $attachment_content       = eval { read_file($attachment->{path}) } if !$attachment_content;
 
   } else {

-    # strip path
-    $attributes{Path}     =  $attachment;

     $attributes{filename} =  $attachment;
     $attributes{filename} =~ s:.*\Q$self->{fileid}\E:: if $self->{fileid};
     $attributes{filename} =~ s:.*/::g;
     $attributes{filename} =  $attachment;
     $attributes{filename} =~ s:.*\Q$self->{fileid}\E:: if $self->{fileid};
     $attributes{filename} =~ s:.*/::g;


@@ -164,9 +160,9 @@ sub _create_attachment_part {
   return undef if $email_journal > 1 && !defined $attachment_content;
 
   $attachment_content ||= ' ';
   return undef if $email_journal > 1 && !defined $attachment_content;
 
   $attachment_content ||= ' ';

-  $attributes{charset}  = $self->{charset} if $self->{charset};
+  $attributes{charset}  = $self->{charset} if $self->{charset} && ($attributes{content_type} =~ m{^text/});

 
 

-  $::lxdebug->message(LXDebug->DEBUG2(), "mail6 mtype=" . $attributes{Type} . " path=" . $attributes{Path} . " filename=" . $attributes{Filename});
+  $::lxdebug->message(LXDebug->DEBUG2(), "mail6 mtype=" . $attributes{Type} . " filename=" . $attributes{Filename});

 
   my $ent;
   if ( $attributes{content_type} eq 'message/rfc822' ) {
 
   my $ent;
   if ( $attributes{content_type} eq 'message/rfc822' ) {


@@ -233,7 +229,7 @@ sub send {
   $self->{charset}       =  'UTF-8';
   $self->{contenttype} ||=  "text/plain";
   $self->{headers}       =  [
   $self->{charset}       =  'UTF-8';
   $self->{contenttype} ||=  "text/plain";
   $self->{headers}       =  [

-    Subject              => encode('MIME-Header',$self->{subject}),
+    Subject              => $self->{subject},

     'Message-ID'         => '<' . $self->_create_message_id . '>',
     'X-Mailer'           => "kivitendo $self->{version}",
   ];
     'Message-ID'         => '<' . $self->_create_message_id . '>',
     'X-Mailer'           => "kivitendo $self->{version}",
   ];