Bei tiefen parse_filters with_objects mit prefix bauen.

diff --git a/SL/Controller/Helper/ParseFilter.pm b/SL/Controller/Helper/ParseFilter.pm
index ac086f594259f24ee9139cb8b486d9e6b65ebd9b..7c393b01ce8126d56af1011dcb09f636ab9a395a 100644 (file)
--- a/SL/Controller/Helper/ParseFilter.pm
+++ b/SL/Controller/Helper/ParseFilter.pm
@@ -74,7 +74,7 @@ sub _pre_parse {
     if ('HASH' eq ref $value) {
       my ($query, $more_objects) = _pre_parse($value, $with_objects, _prefix($prefix, $key));
       push @result,        @$query if $query;
     if ('HASH' eq ref $value) {
       my ($query, $more_objects) = _pre_parse($value, $with_objects, _prefix($prefix, $key));
       push @result,        @$query if $query;

-      push @$with_objects, $key, ($more_objects ? @$more_objects : ());
+      push @$with_objects, _prefix($prefix, $key), ($more_objects ? @$more_objects : ());

     } else {
       push @result, _prefix($prefix, $key) => $value;
     }
     } else {
       push @result, _prefix($prefix, $key) => $value;
     }

diff --git a/t/controllers/helpers/parse_filter.t b/t/controllers/helpers/parse_filter.t
index 198877358062b38c289e03034ef3cb96d9630853..554985d92604407c5791060f5a3702a9f9cd9d61 100644 (file)
--- a/t/controllers/helpers/parse_filter.t
+++ b/t/controllers/helpers/parse_filter.t
@@ -58,7 +58,7 @@ test {
   }
 }, {
   query => [ 'customer.chart.accno' => 'test' ],
   }
 }, {
   query => [ 'customer.chart.accno' => 'test' ],

-  with_objects => bag( 'customer', 'chart' ),
+  with_objects => bag( 'customer', 'customer.chart' ),

 }, 'nested joins';
 
 test {
 }, 'nested joins';
 
 test {


@@ -82,7 +82,7 @@ test {
 },
 {
   query => [ 'customer.chart.accno' => { like => '%1200' } ],
 },
 {
   query => [ 'customer.chart.accno' => { like => '%1200' } ],

-  with_objects => bag('customer', 'chart' ),
+  with_objects => bag('customer', 'customer.chart' ),

 }, 'all together';
 
 
 }, 'all together';
 
 


@@ -100,7 +100,7 @@ test {
                'invoice.customer.name'  => 'test',
                'customer.name'          => 'test',
              }} ],
                'invoice.customer.name'  => 'test',
                'customer.name'          => 'test',
              }} ],

-  'with_objects' => bag( 'invoice', 'customer' )
+  'with_objects' => bag( 'invoice.customer', 'customer', 'invoice' )

 }, 'object in more than one relationship';
 
 test {
 }, 'object in more than one relationship';
 
 test {


@@ -177,3 +177,16 @@ test {
   }
 }, 'deep laundering, check for laundered hash', target => 'launder', launder_to => { };
 
   }
 }, 'deep laundering, check for laundered hash', target => 'launder', launder_to => { };
 

+### bug: sub objects
+
+test {
+  order => {
+    customer => {
+      'name:substr::ilike' => 'test',
+    }
+  }
+}, {
+  query => [ 'order.customer.name' => { ilike => '%test%' } ],
+  with_objects => bag('order.customer', 'order'),
+}, 'sub objects have to retain their prefix';
+