itmes_sorted liefert immer eine Array-Referenz ...

um unvorhersehbare Dinge durch wantarray zu vermeiden.

diff --git a/SL/DB/DeliveryOrder.pm b/SL/DB/DeliveryOrder.pm
index c00bcaf612102db77ace9c2799d29986bee08d3b..6bf602327ee7dfc7de44fd552f7ea1ace2d5057e 100644 (file)
--- a/SL/DB/DeliveryOrder.pm
+++ b/SL/DB/DeliveryOrder.pm
@@ -28,8 +28,7 @@ sub items { goto &orderitems; }
 sub items_sorted {
   my ($self) = @_;
 
-  my @sorted =  sort {$a->id <=> $b->id } @{ $self->items };
-  return wantarray ? @sorted : \@sorted;
+  return [ sort {$a->id <=> $b->id } @{ $self->items } ];
 }
 
 sub sales_order {

diff --git a/SL/DB/Invoice.pm b/SL/DB/Invoice.pm
index 2382c6e126275d817f0a3e9d384483a1571210be..302179c807777fb9eafef980f8d70482c8bf6cfb 100644 (file)
--- a/SL/DB/Invoice.pm
+++ b/SL/DB/Invoice.pm
@@ -50,8 +50,7 @@ sub items { goto &invoiceitems; }
 sub items_sorted {
   my ($self) = @_;
 
-  my @sorted =  sort {$a->id <=> $b->id } @{ $self->items };
-  return wantarray ? @sorted : \@sorted;
+  return [ sort {$a->id <=> $b->id } @{ $self->items } ];
 }
 
 sub is_sales {

diff --git a/SL/DB/Order.pm b/SL/DB/Order.pm
index f4ca003a2d6cd61da17a5a3c30f7e08ccd3f0b93..00886d67e8c4aa2d84666ddeac874c17231bbbbb 100644 (file)
--- a/SL/DB/Order.pm
+++ b/SL/DB/Order.pm
@@ -42,8 +42,7 @@ sub items { goto &orderitems; }
 sub items_sorted {
   my ($self) = @_;
 
-  my @sorted =  sort {$a->id <=> $b->id } @{ $self->items };
-  return wantarray ? @sorted : \@sorted;
+  return [ sort {$a->id <=> $b->id } @{ $self->items } ];
 }
 
 sub type {

diff --git a/SL/DB/PurchaseInvoice.pm b/SL/DB/PurchaseInvoice.pm
index 01885e7ea5d6c62690aa50448bceafa6078fe301..61d93558bbed0cea3aa4b52bacf24a36cc63e961 100644 (file)
--- a/SL/DB/PurchaseInvoice.pm
+++ b/SL/DB/PurchaseInvoice.pm
@@ -32,8 +32,7 @@ sub items { goto &invoiceitems; }
 sub items_sorted {
   my ($self) = @_;
 
-  my @sorted =  sort {$a->id <=> $b->id } @{ $self->items };
-  return wantarray ? @sorted : \@sorted;
+  return [ sort {$a->id <=> $b->id } @{ $self->items } ];
 }
 
 sub is_sales {